guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#57744] [PATCH 0/3] Add shirah and dependencies


From: Christopher Baines
Subject: [bug#57744] [PATCH 0/3] Add shirah and dependencies
Date: Wed, 14 Sep 2022 09:09:33 +0100
User-agent: mu4e 1.6.11; emacs 28.1

M <matf@disr.it> writes:

> shirah is a terminal-based ebook reader, which alone I'd see as a nice
> addition to Guix packages considering how light, flexible and
> customizable (themes, opacity, font options, keybindings) terminal
> emulators are, but it also comes with an optional RSVP mode for speed
> reading, which can be pretty convenient for a terminal reader since
> terminal windows can be resized to very small geometry without
> breaking. shirah also supports basic ebook-reading features, like
> resuming a read, or browsing from the TOC.
>
> M (3):
>   gnu: Add python-ebooklib.
>   gnu: Add python-syllables.
>   gnu: Add shirah.
>
>  gnu/packages/ebook.scm      | 40 +++++++++++++++++++++++++++++++++++++
>  gnu/packages/python-xyz.scm | 20 +++++++++++++++++++
>  2 files changed, 60 insertions(+)


Hey,

These generally look good to me, but I think there are a few things to
fix before merging.

The license information looks off for all packages, can you take a look?

Also, the linter makes some comments about some package synopsis.

Thanks,

Chris

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]