guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#57891] [PATCH 1/1] gnu: Add emacs-org-roam-ui.


From: Maxime Devos
Subject: [bug#57891] [PATCH 1/1] gnu: Add emacs-org-roam-ui.
Date: Sun, 18 Sep 2022 21:09:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0



On 18-09-2022 19:43, Fredrik Salomonsson wrote:
Nicolas Graves<ngraves@ngraves.fr>  writes:

IIRC, there's an issue with packaging guidelines because the package
contains minified js.

I'm not sure that's possible, but we could try to re-generate those
minified js files in a sub-package or something like that.

I couldn't find anything about this in the guidelines.

Some relevant parts (mostly, it boils down to 'minified js' not counting as source code, but binaries):

 * (guix)Introduction:

   [...] Guix makes it easy [...] to build packages from source, [...]

 * (guix)Binary Installation

   Note: If you do not enable substitutes, Guix will end up
   building _everything_ from source on your machine,

 * (guix)Features

   When a pre-built binary for a ‘/gnu/store’ item is
   available from an external source—a “substitute”, Guix just downloads
   it and unpacks it; otherwise, it builds the package from source,

 * (guix)Additional Build Options

   Fetch and return the source of PACKAGE-OR-DERIVATION [...]

 * (guix) Snippets versus Phases
   Origin snippets are typically used to remove unwanted files such as
   bundled libraries, [...]


 * (guix)Submitting Patches

  8. Make sure the package does not use bundled copies of software
     already available as separate packages.

     Sometimes, packages include copies of the source code of their
     dependencies as a convenience for users.  However, as a
     distribution, we want to make sure that such packages end up using
     the copy we already have in the distribution, if there is one.
     This [...], and allows the distribution to make transverse changes
     such as applying security updates for a given software package in a
     single place and have them affect the whole system—something that
     bundled copies prevent.

  ‘Minified JS that we don't know how to rebuild’ doesn't mesh well with
  such 'transverse changes' and "guix build --source will return the
  source code".

Greetings,
Maxime.

Attachment: OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]