guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#57871: [PATCH] ideviceinstaller: new package


From: Julien Lepiller
Subject: bug#57871: [PATCH] ideviceinstaller: new package
Date: Thu, 22 Sep 2022 07:44:54 +0200

Pushed to master as 04cad8e29ed85be838921c7fa05f7c5bce94b6d1.

I had to change a few things in the final patch:

First of all, please run "guix lint" on your future submissions, so you
can fix some of these issues beforehand.

I changed the source to look directly for the git repository: the
tarballs at github are not always stable, which might break the
package, and a git source is easier to archive in Software Heritage.

I also wrapped a long line in the description, and removed your
comments about versions, since they are not relevant in Guix. This also
fixes an issue about lonely parenthesis. Note that version constraints
like >= 1.2.3 are not relevant in Guix, since packages are not expected
to ever downgrade.

Then, I added the autotools packages (autoconf, automake and libtool)
for the bootstrap phase to run and generate the configure script.

I moved the runtime dependencies (libimobiledevice and other libraries)
to the inputs instead of the native-inputs. There is no difference
between the two for normal compilation, but when cross-compiling, a
software can only link to inputs and propagated-inputs since they are
for the target platform, whereas native-inputs are for the native
platform (the computer performing the build).

Thanks for the patch!





reply via email to

[Prev in Thread] Current Thread [Next in Thread]