guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#57902: [PATCH] New package idevicerestore + libirecovery


From: Julien Lepiller
Subject: bug#57902: [PATCH] New package idevicerestore + libirecovery
Date: Thu, 22 Sep 2022 21:45:10 +0200

Hi Jacob,

pushed to master as 5f9d9471c7ef522a04d9f197346c32d810afae81 and
f7a68436edb0bb1dd8a5dd0d65c38cb2fee16773.

Note that when adding packages to Guix, you have to submit a separate
patch for each package. I took the time to split this patch, but in the
future, please make sure to follow the guidelines at
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html#Submitting-Patches

As with your other patch I pushed today, this patch had a few issues
that "guix lint" would have easily caught.

I fixed line length (which caused wrapping issues), native-inputs vs
inputs, synopsis and description, source from git instead of url.

Also fixed the license of the second package, the source explicitely
says "or later", so it's lgpl3+. (weirdly though, the source says 2.1
or later, but COPYING is lgpl 3). lgpl2.1 is correct for the library,
since the source does not say "or later".

I think you have other patches waiting on the mailing list. It would
help reviewers if you could run "guix lint", fix warnings (except
for the archival one if you get it) and send a v2 on their respective
bug number.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]