[bug#57675] [PATCH v11 7/8] gnu: telegram-desktop: Update to 4.2.0.

[Liliana Marie Prikler]

Am Sonntag, dem 25.09.2022 um 07:52 +0800 schrieb Hilton Chain:
> On Sat, 24 Sep 2022 15:58:33 +0800,
> Liliana Marie Prikler wrote:
> > Please introduce this in an earlier commit.  Also, since this is a
> > third-party package, not a telegram-owned one, it'd be nice if we
> > could use upstream versioning, but that seems tied to another
> > package too (swift in particular).  Alternatively, you could simply
> > use "1.3" as per CMakeLists as a base point.
> 
> I'd tried packaging both crc32c and libdispatch, are those two names
> suitable? And then, what's the proper place to place libdispatch in?
Probably maybe. I'm not aware of any other project taking their name
(apart from forks, obviously), and they're more than 3 letters each, so
I think it'll be fine. As for the location of libdispatch, if we had a
swift.scm (which we probably won't until someone packages swift), it'd
go there, but for now c.scm is fine imho.

> Applied Gentoo's patch (for unbundling crc32c) to webrtc-for-
> telegram-desktop, however when
> configuring telegram-desktop with this, it errors out as follows,
> what should I do next?
Uhm... which patch is "Gentoo's patch"?  I don't see anything relevant
here [1].

> #+BEGIN_QUOTE
> CMake Error at Telegram/CMakeLists.txt:7 (add_executable):
>   Target "Telegram" links to target "Crc32c::crc32c" but the target
> was not
>   found.  Perhaps a find_package() call is missing for an IMPORTED
> target, or
>   an ALIAS target is missing?
> 
> CMake Error at Telegram/cmake/lib_tgcalls.cmake:7 (add_library):
>   Target "lib_tgcalls" links to target "Crc32c::crc32c" but the
> target was
>   not found.  Perhaps a find_package() call is missing for an
> IMPORTED
>   target, or an ALIAS target is missing?
> Call Stack (most recent call first):
>   Telegram/CMakeLists.txt:34 (include)
> 
> 
> CMake Error at Telegram/cmake/td_ui.cmake:7 (add_library):
>   Target "td_ui" links to target "Crc32c::crc32c" but the target was
> not
>   found.  Perhaps a find_package() call is missing for an IMPORTED
> target, or
>   an ALIAS target is missing?
> Call Stack (most recent call first):
>   Telegram/CMakeLists.txt:39 (include)
> #+END_QUOTE
Hmm, I think you'll have to patch the CMakeLists, which expect a
slightly different version.  You could also try packaging a second
crc32c, which inherits from upstream, but uses the Telegram-blessed
commit.

Cheers

[1] https://gitweb.gentoo.org/repo/gentoo.git/tree/net-im/telegram-desktop/files