guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#58140] [PATCH 2/6] gnu: Add kaldi-for-vosk.


From: Nicolas Graves
Subject: [bug#58140] [PATCH 2/6] gnu: Add kaldi-for-vosk.
Date: Thu, 29 Sep 2022 10:20:47 +0200

> Trailing #t haven't been required since a long time.
A big part of the code, and in particular old forms, come from the code
of the current kaldi package. Should I also change the same code chunks
for kaldi in an additional patch ?

> If it's Linux only, you can use the 'supported-systems' field for that,
> see (gnu packages linux) for examples.
I don't really know that. Ydotool probably only work on Linux, since
they rely on linux keycodes. I don't know for X. Maybe someone should
test. Should I suppose it only supports Linux by default?

> Why select an older version?  Would keeping the original (and more
> up-to-date) version work?  To avoid a name conflict between the openfst
> (which would be inconvenient for "guix show", "guix install", "guix
> shell"), you can override the 'name' field.

No, it doesn't work and that's the reason why I used this version. It
might however work with the version that's present for kaldi (1.7.3
IIRC), I can test that. But the flags aren't the same, so we probably
should do another package anyway.

I didn't change the name, but I also haven't exported the variable
(define instead of define-public). I expected the package to not be
available through "guix search" or "guix install". Is that OK?

I've done a V3, testing it before sending. 

--
Best regards,
Nicolas Graves





reply via email to

[Prev in Thread] Current Thread [Next in Thread]