|
From: | Pavel Shlyak |
Subject: | [bug#58125] [PATCH] gnu: Add nm-tray |
Date: | Wed, 5 Oct 2022 17:46:50 +0300 |
> Except for the initial line(?), the commit message is for tor the Subject line (-:. I didn’t get you > Please write the actual copyright holder (likely the relevant members of this team or perhaps their employer, depending on how things are set up) -- AFAIK, "PantherX OS Team" is a not some legal entity that can hold copyright. Done > I don't think this module should unconditionally import that, to help with keeping "guix ... package" fast when the kde-frameworks isn't actually used. I didn’t get that, too > Could you add some information, more specifically something to distinguish nm-applet from nm-applet? Currently, it doesn't give any information that helps the user with choosing between nm-tray nad nm-applet. Done > Why? AFAICT, there are no git submodules. True > Can you test that icons are displayed properly in a pure environment ("guix shell --pure nm-tray -- …»)? They are not. I don’t know how to get them to work. > could you set WITH_MODEMMANAGER_SUPPORT? It looks like it’s not yet implemented in the app. Instead, I have removed modem manager from inputs. |
0001-gnu-Add-nm-tray.patch
Description: Binary data
|
[Prev in Thread] | Current Thread | [Next in Thread] |