guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#58365] [PATCH 0/6] Support #:tests? in guile-build-system


From: Maxime Devos
Subject: [bug#58365] [PATCH 0/6] Support #:tests? in guile-build-system
Date: Fri, 7 Oct 2022 22:47:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0

Fixes: <https://issues.guix.gnu.org/58337>

guile-build-system can't guess where the tests are located, so currently it's opt-in, via #:test-script. After this patch series, it is currently only used by guile-ffi-fftw, but other guile-build-system packages that use SRFI-64 could potentially use it too (e.g. guile-srfi-117, which is not packages or even released yet).

* First commit: package a test driver, for nicer output and for proper exit status. I copied test-driver.scm to aux-files such that test-driver.scm can be changed without worrying about rebuilds. OTOH, it isn't modified that often, so that could be left out.

Also, copying test-driver.scm causes the following:

guix build: warning: failed to load '(gnu packages aux-files test-driver)':
no code for module (gnu packages aux-files test-driver)
hint: File `/home/antipode/source-code/guix-master/gnu/packages/aux-files/test-driver.scm' should probably start with:

     (define-module (gnu packages aux-files test-driver))

Whatever code does this loading, should probably be modified to not load things under aux-files.

Going by "git log", the upstream of this test driver is Guix itself.

* Second commit: add support for #:tests?, using the test driver.
* Third commit: use it in guile-ffi-fftw.
* Fourth and fifth commit: cleanup of guile-ffi-fftw.
* Sixth commit: adjust guile-ac-d-bus to new 'check' phase

Only the initial commit is required for adding support for tests.

I'll leave building dependencies to <https://qa.guix.gnu.org/>.

Greetings,
Maxime.

Attachment: OpenPGP_0x49E3EE22191725EE.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]