[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#58386] [PATCH 2/2] gnu: Add passage.
From: |
Tobias Geerinckx-Rice |
Subject: |
[bug#58386] [PATCH 2/2] gnu: Add passage. |
Date: |
Sun, 09 Oct 2022 01:05:44 +0200 |
Heyo,
Nicolas Graves via Guix-patches via 写道:
+(define-public passage
Thanks!
Most points below can be fixed up by a committer, including the
description, but those tend to sound better when written by an
actual user. If you'd like to give it a try.
+ (build-system copy-build-system)
+ (propagated-inputs
+ (list util-linux git qrencode sed tree age))
Super-nitpick: inputs conventionally hang out a bit lower, under
the arguments field.
+ (build-system copy-build-system)
Duped.
+ (arguments
+ '(#:phases (modify-phases %standard-phases
+ (add-after 'unpack 'rename-exe
s/exe/script/ (or sure, executable).
+ (lambda _
+ (rename-file "src/password-store.sh"
+ "src/passage"))))
+ #:install-plan
+ (list '("src/passage" "/bin/")
+ '("src/completion/pass.bash-completion"
+ "/share/bash-completion/completions/")
OK, I've been looking at this for an embarrasingly long time
trying to figure out what you're trying to communicate with '(…
(list '(…))). It seems very deliberate. Any hints? :-p
+ (home-page "https://github.com/FiloSottile/passage")
+ (synopsis "A fork of the password-store encrypted password
manager")
Another nitpic^Wcool tip: @command{} & friends work here just as
well as in the description. There's no difference.
The text should describe the package, not its ancestry.
+ (description "This package provides a fork of the
@code{password-store}
+encrypted password manager. It relies on @code{age} instead of
+@code{gnupg}.")
Same here. I know all of these words but what do they mean?
+ (license license:gpl2+)))
Checked.
+
(define-public pass-otp
(package
(name "pass-otp")
I've made the choice to rename the existing passage game to
passage-game in a first commit, I hope it's OK.
No, I don't think it is. Adding this script need not affect other
packages.
Kind regards,
T G-R
signature.asc
Description: PGP signature