[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#58208] [PATCH 6/7] gnu: Add vamp-aubio-plugins.
From: |
( |
Subject: |
[bug#58208] [PATCH 6/7] gnu: Add vamp-aubio-plugins. |
Date: |
Thu, 27 Oct 2022 20:05:18 +0100 |
On Sat Oct 1, 2022 at 1:22 AM BST, Lilah Tascheter via Guix-patches via wrote:
> + (uri (string-append "https://aubio.org/pub/vamp-aubio-plugins/"
> + "vamp-aubio-plugins-" version ".tar.bz2"))
Add a file-name field.
> + (sha256
> + (base32
> + "1gpcg7hih42qmys8a9zylgas3xfrzqijasgaphm43bmiw7vrvxis"))
One space indents here.
> + (snippet '(begin ;; remove outdated & bundled waf
> + (delete-file "waf")
> + (delete-file-recursively "waflib")))))
Use gexp instead of quote here,
(snippet
#~(begin
(delete-file "waf")
(delete-file-recursively "waflib")))
> + (arguments
> + `(#:tests? #f ;; no tests available
> + #:phases
> + (modify-phases %standard-phases
> + (add-before 'configure 'setup-waf
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((waf (assoc-ref inputs "python-waf")))
> + (copy-file (string-append waf "/bin/waf") "waf")))))))
Use the modern argument style (and correct comment style),
(arguments
(list #:tests? #f ;no tests
#:phases
#~(modify-phases %standard-phases
(add-before 'configure 'setup-waf
(lambda* (#:key inputs #:allow-other-keys)
(copy-file (search-input-file inputs "bin/waf")
"waf"))))))
> + (native-search-paths
> + (list (search-path-specification
> + (variable "VAMP_PATH")
> + (files '("lib/vamp")))))
Use the ``$VAMP_PATH'' variable here.
> + (description "A set of VAMP plugins wrapping the audio annotation
> features
> +of Aubio for use in a VAMP host. Includes plugins for note tracking, energy
guix lint says "sentences in description should be followed by two
spaces"; remember to run it for every package you write :) Also, full
sentences.
> + (home-page "https://aubio.org/vamp-aubio-plugins/")
Move home-page, etc etc :)
-- (
- [bug#58208] [PATCH 6/7] gnu: Add vamp-aubio-plugins.,
( <=