guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#58587: [PATCH 04/14] build-system: Add pyproject-build-system.


From: Marius Bakke
Subject: bug#58587: [PATCH 04/14] build-system: Add pyproject-build-system.
Date: Thu, 27 Oct 2022 21:32:23 +0200

Marius Bakke <marius@gnu.org> skriver:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> skriver:
>
>> Hello,
>>
>> Marius Bakke <marius@gnu.org> writes:
>>
>>> From: Lars-Dominik Braun <lars@6xq.net>
>>>
>>> +              ;; Prefer pytest
>>> +              (if pytest 'pytest #f)
>>> +              (if nosetests 'nose #f)
>>> +              (if nose2 'nose2 #f)
>>> +              ;; But fall back to setup.py, which should work for most
>>> +              ;; packages. XXX: would be nice not to depend on setup.py 
>>> here? fails
>>> +              ;; more often than not to find any tests at all. Maybe we 
>>> can run
>>> +              ;; `python -m unittest`?
>>> +              (if have-setup-py 'setup.py #f))))
>>> +        (format #t "Using ~a~%" use-test-backend)
>>> +        (match use-test-backend
>>> +          ('pytest
>>> +           (apply invoke (cons pytest (or test-flags '("-vv")))))
>>> +          ('nose
>>> +           (apply invoke (cons nosetests (or test-flags '("-v")))))
>>> +          ('nose2
>>> +           (apply invoke (cons nose2 (or test-flags '("-v" 
>>> "--pretty-assert")))))
>>
>> I think I'd leave the defaults in and document it that way.
>
> By leave, you mean:
>
>   (apply invoke "pytest" "-vv" test-flags)
>
> ?

I made this change in e944734ef9afa1ac9b46579934482b7d909ed24e.

The patches are now merged!

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]