[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#58754] [PATCH] gnu: Add new variable gkermit
From: |
Christopher Baines |
Subject: |
[bug#58754] [PATCH] gnu: Add new variable gkermit |
Date: |
Sat, 05 Nov 2022 11:32:19 +0100 |
User-agent: |
mu4e 1.8.9; emacs 28.1 |
路辉 <luhux76@gmail.com> writes:
> add new tool for embedded developing
Thanks for the patch. I've noted two hopefully minor issues below. Would
you be able to take a look at sending an updated patch?
> +(define-public gkermit
> + (package
> + (name "gkermit")
> + (version "2.01")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/KermitProject/gkermit")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0njxzwnvanrdnx6cs7y0136g2179wx8wbqk8iqxpb48dr2hg7zn1"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f
From looking at the source, I guess the reason for this is that there
are no included tests to run. If that is correct, it would be good to
note the reason in a comment.
> + #:make-flags (list (string-append "CC="
> + ,(cc-for-target))
> + (string-append "PREFIX="
> + (assoc-ref %outputs "out")))
> + #:phases (modify-phases %standard-phases
> + (delete 'configure)
> + (add-before 'build 'replace-hardcodepath
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (doc (string-append out "/share/doc"))
> + (man1 (string-append out "/share/man/man1"))
> + (info (string-append out "/share/info")))
> + (substitute* "makefile"
> + (("/usr/local/bin")
> + bin)
> + (("/usr/man/manl")
> + man1) ;may be a typo err?
> + (("/usr/local/doc")
> + doc)
> + (("/usr/local/info")
> + info)
> + (("CC=cc")
> + "CC ?= cc"))
> + (mkdir-p bin)
> + (mkdir-p doc)
> + (mkdir-p man1)
> + (mkdir-p info)))))))
> +
> + (home-page "https://github.com/KermitProject/gkermit")
> + (synopsis "Kermit for UNIX")
> + (description
> + "Use for uploading and downloading files with Kermit protocol")
> + (license license:gpl2)))
Can you check this, at least some files I looked at weren't strict gpl2
only.
Thanks,
Chris
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#58754] [PATCH] gnu: Add new variable gkermit,
Christopher Baines <=