[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59223] [PATCH] services: gitolite: Use the correct variable for the
From: |
Christopher Baines |
Subject: |
[bug#59223] [PATCH] services: gitolite: Use the correct variable for the user-group |
Date: |
Thu, 17 Nov 2022 12:11:30 +0000 |
User-agent: |
mu4e 1.8.11; emacs 28.2 |
EuAndreh via Guix-patches via <guix-patches@gnu.org> writes:
> The default value for <gitolite-configuration> has "git" for both the
> values of the user and the group, as costumary, which means that unless
> someone uses a custom configuration and chooses different strings for
> user and group, this wouldn't show up.
>
> * gnu/services/version-control.scm (gitolite-accounts): Use the correct
> variable for the name of a (user-group ...).
> ---
>
> I did a "git grep user-group gnu/services/" and looked at the returned
> entries. After a quick cursory look, either all the entries had a
> hard-coded string value, or picked the correct variable for the group
> name. So I think this one is a one-off :)
>
> This surfaced after a debugging session with mirai on IRC earlier today.
>
> gnu/services/version-control.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/services/version-control.scm
> b/gnu/services/version-control.scm
> index b6b78e504e..86d40bdbe3 100644
> --- a/gnu/services/version-control.scm
> +++ b/gnu/services/version-control.scm
> @@ -313,7 +313,7 @@ (define gitolite-accounts
> (($ <gitolite-configuration> package user group home-directory
> rc-file admin-pubkey)
> ;; User group and account to run Gitolite.
> - (list (user-group (name user) (system? #t))
> + (list (user-group (name group) (system? #t))
> (user-account
> (name user)
> (group group)
Good spot! I've pushed this to master as
35ef5fca0ac997680e47942e25f403fb3ec54c7d.
Chris
signature.asc
Description: PGP signature