[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise.
From: |
( |
Subject: |
[bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise. |
Date: |
Sun, 20 Nov 2022 13:53:28 +0000 |
Heya,
Thanks for splitting them! A few remarks:
On Sun Nov 20, 2022 at 1:47 PM GMT, Felix Lechner wrote:
> * gnu/packages/golang.scm
> (go-github-com-nathan-osman-go-sunrise): New variable.
Indentation for this should look something like:
* gnu/packages/golang.scm (go-github-com-nathan-osman-go-sunrise):
New variable.
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -2485,6 +2485,33 @@ (define-public go-gopkg-in-go-playground-validator-v9
> + (arguments
> + '(#:import-path "github.com/nathan-osman/go-sunrise"))
Please use
(list #:import-path ...)
instead.
> + (synopsis "Calculates the sunrise and sunset times for a given
> location")
Maybe change this to:
(synopsis "Calculate sunrise and sunset times in Go")
> + (description
> + "To calculate the sunrise and sunset times, you will need the date of
> your
> +observation and the geographical coordinates in latitude and longitude for
> the
> +location.")
How about this:
(description
"This package provides a Go library for calculating sunrise and
sunset times from geographical coordinates and a date.")
-- (
- [bug#59399] [PATCH 3/4] gnu: Add go-github-com-hebcal-hebcal-go., (continued)
- [bug#59399] [PATCH 4/4] gnu: Add hebcal., Felix Lechner, 2022/11/20
- [bug#59399] [PATCH 4/4] gnu: Add hebcal., (, 2022/11/20
- [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise., Felix Lechner, 2022/11/20
- [bug#59399] [PATCH 3/4] gnu: Add go-github-com-hebcal-hebcal-go., Felix Lechner, 2022/11/20
- [bug#59399] [PATCH 2/4] gnu: Add go-github-com-hebcal-gematriya., Felix Lechner, 2022/11/20
- [bug#59399] [PATCH 4/4] gnu: Add hebcal., Felix Lechner, 2022/11/20
- [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise., (, 2022/11/20
- [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise., Christopher Baines, 2022/11/24
- [bug#59399] [PATCH 1/4] gnu: Add go-github-com-nathan-osman-go-sunrise.,
( <=