[bug#59418] [PATCH] gnu: add raider

[宋文武]

Ahriman <ahriman@fedora.email> writes:

Hello,
> * gnu/packages/gnome.scm (raider): New variable.
> ---
>  gnu/packages/gnome.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 3d942635a2..08b6c4263a 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -4956,6 +4956,46 @@ (define-public glib-networking
>  from the GSettings schemas in gsettings-desktop-schemas.")
>      (license license:lgpl2.1+)))
>  
> +(define-public raider
> +  (package
> +    (name "raider")
> +    (version "1.3.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/ADBeveridge/raider/";)
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "0ll9220d6qf9m7wdi5xhq69p8h8whs7l5h5nzdhlbn99qh5388bz"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list #:meson meson-0.63
Does the default meson-0.60 not works?

> +           #:phases #~(modify-phases %standard-phases
> +                        (add-after 'unpack 'patch-paths
> +                          (lambda* (#:key inputs #:allow-other-keys)
> +                            (substitute* 
> "data/com.github.ADBeveridge.Raider.gschema.xml"
> +                              (("/usr/bin/shred")
> +                               (which "shred"))))))))
> +    (native-inputs (list gettext-minimal
> +                         pkg-config
> +                         cmake
> +                         `(,glib "bin")
> +                         desktop-file-utils
> +                         itstool
> +                         gobject-introspection
> +                         blueprint-compiler
> +                         libadwaita
> +                         gtk

I think libadwaita and gtk should go into inputs, native-inputs are for
binaries needed at build time, while inputs are dependencies of runtime.
> +                         `(,gtk "bin")))
> +    (home-page "https://github.com/ADBeveridge/raider";)
> +    (synopsis "File shredder for GNOME")

Maybe "Securely delete your files" as in the shortdesc of raider.doap.
As "shredder" is not a very clear word...

> +    (description
> +     "Raider is a simple shredding program built for GNOME.  Also known as 
> File
> +Shredder, it uses the GNU Core Utility called shred.")
> +    (license license:gpl3)))

According to the source, it should gpl3+.
> +
>  (define-public rest
>    (package
>      (name "rest")
>
> base-commit: 347733bcde2edb60bc831d363971c488eb74e3f8

Could you send an update patch, thank you!