[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#54379] [PATCH v4 1/6] gnu: pipewire: Remove pipewire 0.2.
From: |
Josselin Poiret |
Subject: |
[bug#54379] [PATCH v4 1/6] gnu: pipewire: Remove pipewire 0.2. |
Date: |
Sun, 04 Dec 2022 11:18:14 +0100 |
Hi Brendan and Kevin,
'Brendan Tildesley <mail@brendan.scot> writes:
> Same as v3 but uses PREFIX instead of DESTDIR for libfreeaptx.
This patch totally flew under my radar before, but now that I wanted to
add aptX support I finally found it (after writing the libfreeaptx
definition myself first :p).
Looks good overall, I'm using it without any issues, but I have a couple
of very small nitpicks:
* First of all, patch 1 doesn't cleanly apply on master anymore (which
is normal). To make it easier for maintainers to merge your patches,
you should specify base-commit in your patches using the --base
option, so that they know what patch this was supposed to cleanly
apply on;
* in patch 5, you apparently left an entry in the commit message about
the `/etc` change, even though you separated it into its own commit;
* while we're at it, there's a small typo in patch 1's commit message,
`theinput` -> `the input`;
* if you're inheriting patches from someone else, you should consider
either leaving them as the primary author if you're keeping their
changes as-is, or putting them in the commit message as
Co-authored-by:. It's not really an issue here I think, but something
to remember.
Best,
--
Josselin Poiret
- [bug#54379] [PATCH v4 1/6] gnu: pipewire: Remove pipewire 0.2.,
Josselin Poiret <=