[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#60212: [PATCH] gnu: Add emacs-fzf.
From: |
Nicolas Goaziou |
Subject: |
bug#60212: [PATCH] gnu: Add emacs-fzf. |
Date: |
Tue, 20 Dec 2022 11:25:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Hello,
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (emacs-fzf): New variable.
Thank you.
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'patch-fzf-executable
> + (lambda* (#:key inputs #:allow-other-keys)
> + (make-file-writable "fzf.el")
Nitpick: The expression above is usually not necessary, even though some
package definitions use it.
> + (emacs-substitute-variables "fzf.el"
> + ("fzf/executable" (search-input-file inputs
> "/bin/fzf"))))))))
> + (inputs (list fzf))
> + (home-page "https://github.com/bling/fzf.el")
> + (synopsis "Front-end for fzf")
I expounded it a bit.
> + (description "An @command{emacs} front-end for @command{fzf}.")
Please write full sentences in descriptions, even if upstream does not.
Also, "@command{emacs}" conveys no more information than "Emacs". So
does "@command{fzf}" vs "Fzf". The simpler the better, IMO.
Applied!
Regards,
--
Nicolas Goaziou