[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#59761] [PATCH 0/2] Add u-boot-ts7970-q-2g-1000mhz-c.
From: |
Ricardo Wurmus |
Subject: |
[bug#59761] [PATCH 0/2] Add u-boot-ts7970-q-2g-1000mhz-c. |
Date: |
Thu, 29 Dec 2022 20:33:16 +0100 |
User-agent: |
mu4e 1.8.13; emacs 28.2 |
Hi Maxim,
there seems to be some overlap between this and
https://issues.guix.gnu.org/60224. Looking just at v4 I only have one
comment.
In your substitute* replacements it’s better not to use string-append.
You can include real line breaks in a string and escape line breaks with
\. This is preferable to gluing strings together. For something as
long as the replacements in this package consider using a patch file
instead. This has the added advantage of failing the build when the
patch cannot be applied cleanly.
The rest looks good to me.
--
Ricardo
- [bug#59761] [PATCH 2/2] gnu: Add u-boot-ts7970-q-2g-1000mhz-c., (continued)