[bug#59092] [PATCH] gnu: Add motif

[Simon Tournier]

Hi,

The recipe LGTM but

 1. I have not tried to build it,
 2. I have not given a quick look to the source.
 

On jeu., 22 déc. 2022 at 22:34, Andy Tai <lichengtai@gmail.com> wrote:
> +(define-public motif
> +  (let ((commit   "59858b0811e8d9dfaeb142f2b5a96f55482be1ed")
> +        (revision "0"))
> +      (package
> +        (name "motif")
> +        (version (git-version "2.3.8" revision commit))

Maybe it could helpful for later update to mention with a comment why
this commit is required and the release version is not enough.

> +        (source
> +          (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                    (url "https://git.code.sf.net/p/motif/code";)
> +                    (commit commit)))
> +            (file-name (git-file-name name version))
> +            (sha256
> +              (base32
> +                "0yycq0vzga9qmgbfzn2d02ilpwxixwdv2j1d8sddl4dripcrg21m"))))
> +        (build-system gnu-build-system)
> +        (inputs
> +          (list libx11 xorgproto))
> +        (propagated-inputs
> +          (list fontconfig freetype libxext libxft libxpm libxt xbitmaps))
> +        (native-inputs
> +            (list autoconf automake byacc flex  libtool pkg-config))
                                                --^
                                       Extra space

Here, an extra space. :-)

> +        (home-page "https://motif.ics.com/motif";)
> +        (synopsis "Motif toolkit for the X window system")
> +        (description "Motif is the industry standard graphical user 
> interface, (as

Usually, we try to avoid such “the industry” and instead only “Motif is
a standard graphical user interface, …”

And the linter [1] complains about «description Validate package
descriptions sentences in description should be followed by two spaces;
possible infractions at 155, 343».

1: <https://qa.guix.gnu.org/issue/59092>

Cheers,
simon