[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#60735] [PATCH v2 2/3] system: Deprecate hosts-file.
From: |
Ludovic Courtès |
Subject: |
[bug#60735] [PATCH v2 2/3] system: Deprecate hosts-file. |
Date: |
Mon, 23 Jan 2023 23:37:49 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Bruno Victal <mirai@makinata.eu> skribis:
> * gnu/system.scm (operating-system-hosts-file): Deprecate procedure.
> (warn-hosts-file-field-deprecation): New procedure, helper for
> deprecated variable).
> (operating-system)[hosts-file]: Use helper to warn deprecated field.
> (operating-system-default-essential-services)
> (hurd-default-essential-services): Use hosts-service-type.
> (local-host-aliases): Return a list of host-entry records.
> (default-/etc/hosts): Remove procedure.
> (operating-system-etc-service): Remove hosts file.
> * doc/guix.texi (operating-system Reference)
> (Networking Services) (Virtualization Services): Rewrite documentation
> entries to use hosts-service-type.
> * gnu/tests/ganeti.scm: Use hosts-service-type extension.
> ---
>
> WIP, the ganeti tests fail because host-name is added as an alias of
> localhost.
Before these patches, ‘host-name’ was already an alias of ‘localhost’.
Is there something else interfering?
> + (simple-service 'block-facebook-hosts hosts-service-type
> + (let ((host-pairs
> + (filter-map
> + (lambda (x)
> + (and (not (or (string-null? x)
> + (string-prefix? "#" x)))
> + (remove string-null?
> + (string-split
> + x
> + char-set:whitespace))))
> + (string-split %facebook-host-aliases
> #\newline))))
> + (map (match-lambda
> + ((addr name)
> + (host addr name)))
> + host-pairs)))
It doesn’t matter because it’s removed in the commit that follows I
think using ‘string-tokenize’ instead of ‘string-split’ may bring
simplifications.
> +++ b/gnu/system.scm
> @@ -14,6 +14,7 @@
> ;;; Copyright © 2020, 2022 Efraim Flashner <efraim@flashner.co.il>
> ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
> ;;; Copyright © 2021 raid5atemyhomework <raid5atemyhomework@protonmail.com>
> +;;; Copyright © 2023 Bruno Victal <mirai@makinata.eu>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -31,6 +32,7 @@
> ;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
>
> (define-module (gnu system)
> + #:use-module (guix discovery)
Do we really need this module?
Otherwise LGTM.
Ludo’.
[bug#60735] [PATCH v2 1/3] services: Add etc-hosts-service-type., Ludovic Courtès, 2023/01/23
[bug#60735] [PATCH v2 1/3] services: Add etc-hosts-service-type., Ludovic Courtès, 2023/01/23
[bug#60735] [PATCH v3 1/3] services: Add hosts-service-type., Bruno Victal, 2023/01/27