guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build.


From: Maxim Cournoyer
Subject: [bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build.
Date: Mon, 15 May 2023 09:49:25 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

> * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>: Set “GDK_BACKEND”
> and “GTK_A11Y”.
> ---
>  gnu/packages/gtk.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index de45eb3870..7d76610293 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -616,6 +616,9 @@ (define-public gtksourceview
>                 ;; Tests require a running X server.
>                 (system (string-append Xvfb " :1 &"))
>                 (setenv "DISPLAY" ":1")
> +               ;; For GTK

Nitpick: Add a full stop (period) for standalone comments.  Perhaps
expound how these environment variables are useful to set ('For GTK'
leaves me wondering, as 'gtksourceview' already seems GTK-focused).

> +               (setenv "GDK_BACKEND" "x11")
> +               (setenv "GTK_A11Y" "none")
>                 ;; For the missing /etc/machine-id.
>                 (setenv "DBUS_FATAL_WARNINGS" "0")))))))
>      (native-inputs

Otherwise, LGTM.

-- 
Thanks,
Maxim





reply via email to

[Prev in Thread] Current Thread [Next in Thread]