[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Repository behavior
From: |
Mark Burgess |
Subject: |
Re: Repository behavior |
Date: |
Thu, 09 Nov 2006 18:51:40 +0100 |
User-agent: |
Thunderbird 1.5.0.7 (X11/20060911) |
It would seem to be an error. Would you test the patched version from
SVN, with the patch noted below?
M
Ralph Angenendt wrote:
> lothian+cfengine@cs.utk.edu wrote:
>> So, I'm trying out the Repository variable with cfengine-2.1.21. It
>> copies the .cfsaved files to the repository directory just fine.
>> However, a .cfsaved file is still being left in the original directory.
>>
>> The intent behind using the repository was to avoid problems like
>> changing a file in /etc/cron.daily/ (on a Redhat-ish machine), and
>> having a backup .cfsaved made which also gets executed.
>
> This behaviour began to show with version 2.1.21, before that it worked
> as you (and I) would expect. I assume that it has to to with the changes
> in image.c from 2.1.20 to 2.1.21:
>
> | @@ -1584,30 +1584,28 @@
> | /* rely on prior BufferOverflow() and on strlen(CF_SAVED) <
> CF_BUFFERMARGIN
> | */
> | strcat(backup,CF_SAVED);
> |
> | - if (IsItemIn(VREPOSLIST,backup))
> | + if (!IsItemIn(VREPOSLIST,backup))
> [...]
>
> I'm not a programmer, so I cannot say if I really found the place where
> it broke, but seeing that this went from "item is in list" to "item is
> not in list", I'm a little positive about that this is where something
> could go wrong.
>
>> Is this how the Repository functionality is supposed to work? I know I
>> could do something like have a tidy: that cleans all the .cfsaved files
>> from /etc, but that seems like a hack.
>
> No, it's not supposed to work like that.
>
> Cheers,
>
> Ralph
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Help-cfengine mailing list
> Help-cfengine@gnu.org
> http://lists.gnu.org/mailman/listinfo/help-cfengine
--
Mark Burgess
Professor of Network and System Administration
Oslo University College
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Work: +47 22453272 Email: Mark.Burgess@iu.hio.no
Fax : +47 22453205 WWW : http://www.iu.hio.no/~mark
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~