Re: Very small bug

[Lars Henriksen]

On Mon, Jan 06, 2003 at 07:35:03PM +0100, Dieperink Alwin wrote:
> Hi Yngve,
> 
> Here is a small correction for gnatsweb.pl. Without this, gnatsweb writes a
> warning in the logfile.
> 
> Regards,
> -- Alwin
> 
> 
> 1362c1362
> <            && ($2 !=~ "compatible") )
> ---
> >            && ($2 !~ "compatible") )

There's more. Opera (at least version 6.04) also doesn't like the double
encoding.

Lars Henriksen

diff -u -r1.120 gnatsweb.pl
--- gnatsweb.pl 8 Jan 2003 13:04:17 -0000       1.120
+++ gnatsweb.pl 8 Jan 2003 13:28:06 -0000
@@ -1357,9 +1357,10 @@
   my $body    = $q->escape(get_viewpr_url($pr));
 
   # Netscape Navigator up to and including 4.x should get the URL in
-  # the body encoded only once
-  unless ( ($ENV{'HTTP_USER_AGENT'} =~ "Mozilla\/(.)(.*)") && ($1 < 5)
-           && ($2 !~ "compatible") )
+  # the body encoded only once--and so should Opera.
+  unless (
+     ( $ENV{'HTTP_USER_AGENT'} =~ "Mozilla\/(.)(.*)" && $1 < 5 && $2 !~ 
"compatible" )
+    || $ENV{'HTTP_USER_AGENT'} =~ "Opera\/" )
   {
     $body = $q->escape($body);
   }