Re: patch #1 - towards a generic backend datastore

[Mel Hatzis]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Chad Walstrom wrote:
> Mel Hatzis wrote:
> 
>>No one has responded to my patch thus far. I plan on committing the
>>changes Thursday evening (PST) provided no one speaks up in the
>>meantime.
> 
> 
> I haven't had a chance to look it over in detail, yet.  We haven't
> released 4.1, either, though I'm hoping that my patches and Mike's will
> be the last.  Now is the time to decide whether or not to include your
> patches in 4.1 or wait until 4.2.

There's no harm in applying this patch to 4.1...the changes do not
involve any functional deviations. In fact, there are a few good bug
fixes in the patch, not to mention some performance improvements.

> 
> If we want to wait, I'll get Mike's and my patches in tonight and branch
> off the 4.1 tree from the trunk, making space for you to work on the 4.2
> release.  I'll add clean-up touches to the 4.1 tree for release (if
> there are any), and cherry pick any necessary changes back to trunk.
> 
> If we want to include it in 4.1, then go ahead and apply to the trunk.
> 

OK, I'll go ahead and commit to the mainline tomorrow morning (PST).
Note that I ran the changes through a fairly comprehensive set of
regression tests (which I put together) and they appear to be sound.


I'll have the next patch out for review soon.

- -Mel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCHXkoNF74HmYqaSERAlC+AJkBY8yUz9T6Bvxoakr9PnxLrrODdQCfb7u+
mU01ZNH4cnsUj4WQd8zu0Z8=
=fn4d
-----END PGP SIGNATURE-----