libxenstore.so dependency ignored by make 3.82

[Olaf Hering]

Hello,

after the recent addition of the 'init-xenstore-domain' target the build
of tools/xenstore fails randomly with make 3.82 as shipped with
openSuSE 11.4 and 12.1. 

init-xenstore-domain requires libxenstore.so for linking, and this
dependency is listed as a prereq in init-xenstore-domain target.
However, libxenstore.so is not created before init-xenstore-domain is
about to be linked.

I find that odd since all dependencies are listed. After trying lots of
combinations, like adding a 'foo' target which depends on libxenstore.so
and let init-xenstore-domain depend on foo instead of libxenstore.so,
the rule to create libxenstore.so is not executed before
init-xenstore-domain.

At the time init-xenstore-domain is invoked, only targets libxenstore.a and
libxenstore.so.3.0.1 are made.

The only thing that appears to help is to list init-xenstore-domain
first in ALL_TARGETS.

Does anyone see an obvious flaw in the Makefile below?

Running make with the -d option produces a 40MB output file and since
-jN is used several make processes write to stdout at the same time,
corrupting the output. Whats the best way to check why make thinks that
either libxenstore.so exists for init-xenstore-domain or why
libxenstore.so got dropped as prereq?

Olaf


......
XEN_ROOT=$(CURDIR)/../..
include $(XEN_ROOT)/tools/Rules.mk

MAJOR = 3.0
MINOR = 1

CFLAGS += -Werror
CFLAGS += -I.
CFLAGS += $(CFLAGS_libxenctrl)

CLIENTS := xenstore-exists xenstore-list xenstore-read xenstore-rm 
xenstore-chmod
CLIENTS += xenstore-write xenstore-ls xenstore-watch

XENSTORED_OBJS = xenstored_core.o xenstored_watch.o xenstored_domain.o 
xenstored_transaction.o xs_lib.o talloc.o utils.o tdb.o hashtable.o

XENSTORED_OBJS_$(CONFIG_Linux) = xenstored_linux.o xenstored_posix.o
XENSTORED_OBJS_$(CONFIG_SunOS) = xenstored_solaris.o xenstored_posix.o 
xenstored_probes.o
XENSTORED_OBJS_$(CONFIG_NetBSD) = xenstored_netbsd.o xenstored_posix.o
XENSTORED_OBJS_$(CONFIG_MiniOS) = xenstored_minios.o

XENSTORED_OBJS += $(XENSTORED_OBJS_y)

ifneq ($(XENSTORE_STATIC_CLIENTS),y)
LIBXENSTORE := libxenstore.so
else
LIBXENSTORE := libxenstore.a
xenstore xenstore-control: CFLAGS += -static
endif

ALL_TARGETS = libxenstore.so libxenstore.a clients xs_tdb_dump xenstored 
init-xenstore-domain

ifdef CONFIG_STUBDOM
CFLAGS += -DNO_SOCKETS=1
endif

.PHONY: all
all: $(ALL_TARGETS)

.PHONY: clients
clients: xenstore $(CLIENTS) xenstore-control

ifeq ($(CONFIG_SunOS),y)
xenstored_probes.h: xenstored_probes.d
        dtrace -C -h -s xenstored_probes.d

xenstored_solaris.o: xenstored_probes.h

xenstored_probes.o: xenstored_solaris.o
        dtrace -C -G -s xenstored_probes.d xenstored_solaris.o 

CFLAGS += -DHAVE_DTRACE=1
endif

init-xenstore-domain.o: CFLAGS += $(CFLAGS_libxenguest)

init-xenstore-domain: init-xenstore-domain.o $(LIBXENSTORE)
        $(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) 
$(LDLIBS_libxenstore) -o $@ $(APPEND_LDFLAGS)

xenstored: $(XENSTORED_OBJS)
        $(CC) $(LDFLAGS) $^ $(LDLIBS_libxenctrl) $(SOCKET_LIBS) -o $@ 
$(APPEND_LDFLAGS)

xenstored.a: $(XENSTORED_OBJS)
        $(AR) cr $@ $^

$(CLIENTS): xenstore
        ln -f xenstore $@

xenstore: xenstore_client.o $(LIBXENSTORE)
        $(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ 
$(APPEND_LDFLAGS)

xenstore-control: xenstore_control.o $(LIBXENSTORE)
        $(CC) $(LDFLAGS) $< $(LDLIBS_libxenstore) $(SOCKET_LIBS) -o $@ 
$(APPEND_LDFLAGS)

xs_tdb_dump: xs_tdb_dump.o utils.o tdb.o talloc.o
        $(CC) $(LDFLAGS) $^ -o $@ $(APPEND_LDFLAGS)

libxenstore.so: libxenstore.so.$(MAJOR)
        ln -sf $< $@
libxenstore.so.$(MAJOR): libxenstore.so.$(MAJOR).$(MINOR)
        ln -sf $< $@

xs.opic: CFLAGS += -DUSE_PTHREAD

libxenstore.so.$(MAJOR).$(MINOR): xs.opic xs_lib.opic
        $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenstore.so.$(MAJOR) 
$(SHLIB_LDFLAGS) -o $@ $^ $(SOCKET_LIBS) -lpthread $(APPEND_LDFLAGS)

libxenstore.a: xs.o xs_lib.o
        $(AR) rcs $@ $^

.PHONY: clean
clean:
        rm -f *.a *.o *.opic *.so* xenstored_probes.h
        rm -f xenstored xs_random xs_stress xs_crashme
        rm -f xs_tdb_dump xenstore-control init-xenstore-domain
        rm -f xenstore $(CLIENTS)
        $(RM) $(DEPS)

.PHONY: TAGS
TAGS:
        etags `find . -name '*.[ch]'`

.PHONY: tarball
tarball: clean
        cd .. && tar -c -j -v -h -f xenstore.tar.bz2 xenstore/

.PHONY: install
install: all
        $(INSTALL_DIR) $(DESTDIR)$(BINDIR)
        $(INSTALL_DIR) $(DESTDIR)$(SBINDIR)
        $(INSTALL_DIR) $(DESTDIR)$(INCLUDEDIR)
        $(INSTALL_DIR) $(DESTDIR)/var/run/xenstored
        $(INSTALL_DIR) $(DESTDIR)/var/lib/xenstored
        $(INSTALL_PROG) xenstored $(DESTDIR)$(SBINDIR)
        $(INSTALL_PROG) xenstore-control $(DESTDIR)$(BINDIR)
        $(INSTALL_PROG) xenstore $(DESTDIR)$(BINDIR)
        set -e ; for c in $(CLIENTS) ; do \
                ln -f $(DESTDIR)$(BINDIR)/xenstore $(DESTDIR)$(BINDIR)/$${c} ; \
        done
        $(INSTALL_DIR) $(DESTDIR)$(LIBDIR)
        $(INSTALL_PROG) libxenstore.so.$(MAJOR).$(MINOR) $(DESTDIR)$(LIBDIR)
        ln -sf libxenstore.so.$(MAJOR).$(MINOR) 
$(DESTDIR)$(LIBDIR)/libxenstore.so.$(MAJOR)
        ln -sf libxenstore.so.$(MAJOR) $(DESTDIR)$(LIBDIR)/libxenstore.so
        $(INSTALL_DATA) libxenstore.a $(DESTDIR)$(LIBDIR)
        $(INSTALL_DATA) xs.h $(DESTDIR)$(INCLUDEDIR)
        $(INSTALL_DATA) xs_lib.h $(DESTDIR)$(INCLUDEDIR)

-include $(DEPS)

# never delete any intermediate files.
.SECONDARY: