[Help-smalltalk] Re: [feature] Performance degradation in TCP.Socket (feature request setsockopt for TCP_NODELAY)

[Robin Redeker]

Issue status update for 
http://smalltalk.gnu.org/project/issue/119
Post a follow up: 
http://smalltalk.gnu.org/project/comments/add/119

Project:      GNU Smalltalk
Version:      <none>
Component:    Bindings (other)
Category:     feature requests
Priority:     normal
Assigned to:  bonzinip
Reported by:  elmex
Updated by:   elmex
Status:       patch

The patch enables TCP_NODELAY now for every socket flush as far
as I can see it. Is that intended?

The tcp delay, aka. nagles algorithm has it's applications and
disabling
it should be done only in special applications (eg. where low-latency
for is required) IMO.

So a more optional interface would be better I guess. Something like:

socket setTCPNoDelay: true/false

would be enough IMO.

"valueWithoutBuffering:" is ok, I guess, as additional feature.

The Socket>>#flush method in that patch does always use
valueWithoutBuffering.
I would probably introduce a new method with a more verbost name
instead, 
something like flushWithoutTCPDelay :-)

The patch is ok, I would just make the functionality optional.