[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Help-smalltalk] [PATCH 4/4] jit: The at: optimization is broken for
From: |
Paolo Bonzini |
Subject: |
Re: [Help-smalltalk] [PATCH 4/4] jit: The at: optimization is broken for ContextPart>>#at: -1 |
Date: |
Mon, 07 Oct 2013 09:57:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 27/06/2013 11:07, Paolo Bonzini ha scritto:
> Since you said it happens also with the interpreter, and it is a clear
> bug in classes that have both fixed and indexed instance variables,
> let's leave this one aside for now.
>
> st> thisContext basicAt: -1
> UndefinedObject>>executeStatements
I started debugging this one. One problem is that the
PUSH_LITERAL (arg);
MAKE_DIRTY_BLOCK ();
bytecode does not update sp (via PREPARE_STACK) before MAKE_DIRTY_BLOCK
invokes _gst_make_block_closure. This is a bug in vm.def, and I have a
patch for it. However, alone it does not fix the bug. I'll keep looking.
Paolo
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Help-smalltalk] [PATCH 4/4] jit: The at: optimization is broken for ContextPart>>#at: -1,
Paolo Bonzini <=