Re: reserved lock and other patches

[Noel L Yap]

address@hidden on 2001.03.15 14:13:12
>> I remember testing for these situations when I originally made the patch.
>> Nothing horrendous (ie crash or hang) happens, but I don't really remember
>> exactly what happens (eg warning message, no message, ...).
>
>I think I'd want the commands to work.  In other words, if the outputs of 'cvs
>editors' and maybe other commands are incompatible/unparsable on one end or
>another, the client/server command negotiation should allow for the version
>discrepancy.  I expect that the reservation code shouldn't be a severe problem
>since either the server or client should reject the '-c' option and operation
will
>cease.

Oh, yes, that's right, if either the client or the server doesn't support "-c",
the operation won't go through.

IIRC, "cvs editors" will work regardless of who supports multiple edits since
the client will first check to see if the server supports the feature.  In the
end, "cvs edit" just stores some info in CVS/fileattr.  This info is parsed and
outputted by "cvs editors".


>> Anyway, the new patches will have to be retested and I can say right now that
I
>> won't have the bandwidth to do so (and I haven't figured out exactly how to
add
>> to the regression test suite).  So, ANY VOLUNTEERS?
>
>There's not room in the regression suite to test different client/server
versions
>outside, perhaps, of launching the executable as a server and fiddling with
stdin
>(see the pserver test), but the basic multiple_edits and reservations behavior
>should be checked for.

I agree.  Any volunteers?

>I'd also want to see documentation updates (to cvs.texinfo) before I'd check
this
>in.

It looks like cvs.texinfo is easy enough to change, but can you tell me how I
can test those changes?

Thanks,
Noel



This communication is for informational purposes only.  It is not intended as
an offer or solicitation for the purchase or sale of any financial instrument
or as an official confirmation of any transaction. All market prices, data
and other information are not warranted as to completeness or accuracy and
are subject to change without notice. Any comments or statements made herein
do not necessarily reflect those of J.P. Morgan Chase & Co., its
subsidiaries and affiliates.