info-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Error in the doc C.1.6


From: Pascal Bourguignon
Subject: Error in the doc C.1.6
Date: Sat, 9 Jun 2001 23:42:56 +0200 (CEST)

http://cvshome.org/docs/manual/cvs_18.html#SEC161

The section 'C.1.6 How the modules file "program options" programs are
run' is wrong. It says that:

     The commit and update programs  are locally-based, and are run as
     follows:-
         The program is always run locally.

which is plain false. At least,  when I access the cvs repository thru
ssh with :ext:, the commit and update programs are run on the server:



address@hidden test1]$ cvs commit -m update
Checking in wang;
/cvs/test1/wang,v  <--  wang
new revision: 1.12; previous revision: 1.11
done
cvs server: Executing ''/scripts/commited' '/cvs/test1''
^^^^^^^^^^               

address@hidden test1]$ cvs update
cvs server: Updating .
cvs server: Executing ''/scripts/updated' '/cvs/test1''
^^^^^^^^^^


I think  that the  right thing to  do is  to ALWAYS run  the triggered
programs  on  the  server  side.  Well, when  there  is  no  transport
(CVSROOT=/dir), then the local side  and the server side are the same,
but conceptually, they  should be run on the server  side even in that
case.

They are aready when the :ext: transport is used. I've not tested with
other  transports. The documentation  should be  updated to  match the
implementation which is correct.



In addition,  the handling  of these triggers  should be  improved for
recursive processing. Right now, when we check out the top level:

     cvs checkout .

only the scripts  that are specified for the top  level module (.) are
run, not the scripts that may  be specified for each the modules. (The
files Checkin.prog and Update.prog are  not checked out). I think that
it's not right.

On  the other  hand, if  the trigger  are all  and always  server side
based, there's  not need to  checkout any Checkin.prog  or Update.prog
file...




-- 
__Pascal_Bourguignon__              (o_ Software patents are endangering
()  ASCII ribbon against html email //\ the computer industry all around
/\  and Microsoft attachments.      V_/ the world http://lpf.ai.mit.edu/
1962:DO20I=1.100  2001:my($f)=`fortune`;  http://petition.eurolinux.org/

-----BEGIN GEEK CODE BLOCK-----
Version: 3.1
GCS/IT d? s++:++(+++)>++ a C+++  UB+++L++++$S+X++++>$ P- L+++ E++ W++
N++ o-- K- w------ O- M++$ V PS+E++ Y++ PGP++ t+ 5? X+ R !tv b++(+)
DI+++ D++ G++ e+++ h+(++) r? y---? UF++++
------END GEEK CODE BLOCK------



reply via email to

[Prev in Thread] Current Thread [Next in Thread]