Re: CVS update bug

[Kaz Kylheku]

On Thu, 4 Apr 2002, Greg A. Woods wrote:

> Date: Thu,  4 Apr 2002 21:15:30 -0500 (EST)
> From: Greg A. Woods <address@hidden>
> Reply-To: CVS-II Discussion Mailing List <address@hidden>
> To: Kaz Kylheku <address@hidden>
> Cc: address@hidden
> Subject: Re: CVS update bug
> 
> [ On Thursday, April 4, 2002 at 16:38:32 (-0800), Kaz Kylheku wrote: ]
> > Subject: Re: CVS update bug
> >
> > Firstly, in tag.c it defeats the stupid check that prevents tagging if
> > there are one or more locally added files. If an entry has no RCS
> > version file, we check its status. If its status is T_ADDED, then we
> > simply skip the file.
> 
> That's not exactly a stupid check -- an added file _is_ a modified file
> until it has been committed.

The check I disabled (or rather altered) is not the local modification
check.  It's a separate check for the a missing RCS file.

> That check should only be disabled if 'cvs tag -c' was given
> (i.e. check_uptodate is set)....

That check is not conditional to -c; it happens without -c. If you
tag over some locally added file without -c, you will get the error 
``nothing known about <file>'' and the tagging will fail.

The old logic was:

    if (no RCS file) 
        problem

My fix has this:

    if (no RCS file) 
        if (locally added)
            okay
        else
            problem

-- 
Meta-CVS: solid version control tool with directory structure versioning. 
http://users.footprints.net/~kaz/mcvs.html