[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CVS 1.11.2 Released!

From: Derek Robert Price
Subject: Re: CVS 1.11.2 Released!
Date: Mon, 20 May 2002 14:55:29 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020516

Noel Yap wrote:

--- Derek Robert Price <address@hidden> wrote:

Noel Yap wrote:

Grrr!  It looks like the advisory locks patch still
didn't make it in.  I think the patch have all the
necessary requisites (doc and test patch).  Is it
still missing something?


I've fallen a little bit behind on the email lists,
I won't get into why, but I just found your patch on SourceForge. I'll try and find time to take a look at it so that you can at least get feedback and maybe get the patch into the next release.

Thanks for your patience.

Hey, so long as it's not being ignored outright ...

The LAG (latest and greatest) of this patch was
submitted by Matt Ogilvie (who added docs and tests). Just to be sure you get the right one, here is the


The addition of documentation and test cases is great, but this patch is still way too big. I'll keep trying to deal with it if somebody will chop it into little bite size chunks, one bug fix or feature, its doc, and its tests per chunk.

For instance, the bug fixes Mathew Ogilvie mentions he made as he was working on this should have their own patches. Making edit report editors should be in its own patch. Advisory locks should have its own patch, possibly several when it makes sense, but I didn't read enough to give further advice. The sockPlayer separation is nice too - keep it separate.

Sorry about that, but I really don't have the time for so much unpaid work at the moment.



Email: address@hidden
Public key available from - Key ID 5ECF1609
Fingerprint 511D DCD9 04CE 48A9 CC07  A421 BFBF 5CC2 56A6 AB0E

Get CVS support at
Welcome to the Church of the Holy Cabbage. Lettuce pray

reply via email to

[Prev in Thread] Current Thread [Next in Thread]