Re: cvs 1.11.2 behaviour

[Larry Jones]

Amy Fong writes:
> 
> In cvs 1.11.2, it appears that if someone were to perform a cvs login
> (to a pserver) and there isn't an existing .cvspass file in their home
> directory, it results in an error message followed by an entry
> 
> /1 (null) <encrypted password>

Yes, it's a bug that's already been fixed.  Here's the patch:

Index: login.c
===================================================================
RCS file: /cvs/ccvs/src/login.c,v
retrieving revision 1.67
retrieving revision 1.70
diff -u -r1.67 -r1.70
--- login.c     6 Sep 2001 16:18:29 -0000       1.67
+++ login.c     23 May 2002 18:13:17 -0000      1.70
@@ -313,6 +303,8 @@
        error (1, 0, "CVSROOT: %s", root->original);
     }
 
+    cvsroot_canonical = normalize_cvsroot (root);
+
     /* Yes, the method below reads the user's password file twice when we have
      * to delete an entry.  It's inefficient, but we're not talking about a 
gig of
      * data here.
@@ -325,8 +317,6 @@
        error (0, errno, "warning: failed to open %s for reading", passfile);
        goto process;
     }
-
-    cvsroot_canonical = normalize_cvsroot (root);
 
     /* Check each line to see if we have this entry already. */
     line = 0;

-Larry Jones

There's a connection here, I just know it. -- Calvin