Re: ANN: CVSToys 1.0.0 - commit notification extravaganza

[Hauke Fath]

Am 11.11.2002 um 0:58 Uhr -0800  schrub Kevin Turner:
> On Mon, 2002-11-11 at 00:13, Greg A. Woods wrote:
> >  > Unlike 'loginfo' alone, which will only execute the first
> >  > matching command it finds, FreshCVS's flexible configuration allows for
> >  > any number of actions to take place.
> >
> >  That's bogus.  CVS has always had an "ALL" keyword.
>
> Which gives you ALL or nothing.  That doesn't handle something like
>
> X* command1
> Xsub* command2
>
> Y* command3
>
> ...you don't want ALL to happen for any of commands 1, 2, or 3, but you
> do want both 1 and 2 to happen for Xsubfoo.

Yep. I've tripped over that one, too.

The following patch (against 1.11 sources, iirc) enables matching 
against all regexp entries (as opposed to stopping after the first 
positive and continue with processing the ALL entries).

--- parseinfo.c~        Wed Dec 23 16:15:01 1998
+++ parseinfo.c Fri Dec 10 16:11:07 1999
@@ -148,10 +148,12 @@
            continue;
        }

+#if 0 /* XXX 199912010 hf */
        if (callback_done)
            /* only first matching, plus "ALL"'s */
            continue;
-
+#endif
+
        /* see if the repository matched this regular expression */
        if ((regex_err = re_comp (exp)) != NULL)
        {

Might be useful enough to make it an option.

        hauke

--
         Hauke Fath                      /~\  The ASCII Ribbon Campaign
tangro software components gmbh          \ /    No HTML/RTF in email
     D-69115 Heidelberg                   X     No Word docs in email
 Ruf +49-6221-1333-60, Fax -621          / \  Respect for open standards