Re: pserver core dumps on WinCVS login

[MChojnacki]

Looks like recursive death may have been the whole problem. Now I get no
core dumps, although an empty directory (cvs-servNNNNNN, where NNNNNN is
the process ID for the server) is left in /tmp (not a big deal)...

Thanks for the fix!

Mark Chojnacki
address@hidden
---------------------------


                                                                                
                                                          
                    address@hidden (Larry Jones)                                
                                                  
                    Sent by:                                    To:     
address@hidden                                             
                    info-cvs-bounces+mchojnacki=symcor.c        cc:     
address@hidden                                                  
                    address@hidden                                  Subject:    
 Re: pserver core dumps on WinCVS login                       
                                                                                
                                                          
                                                                                
                                                          
                    02/27/03 12:54 PM                                           
                                                          
                                                                                
                                                          
                                                                                
                                                          




address@hidden writes:
>
> Sorry about that. Here's the first few lines of output for the where
> command within dbx. The final 10 lines are repeated ad nauseum after
> that...

The following patch should avoid the recursive death, maybe then we'll
be able to figure out the root problem.

Index: server.c
===================================================================
RCS file: /cvs/ccvs/src/server.c,v
retrieving revision 1.284.2.1
diff -u -r1.284.2.1 server.c
--- server.c         21 Feb 2003 21:32:55 -0000          1.284.2.1
+++ server.c         27 Feb 2003 17:53:02 -0000
@@ -4863,8 +4863,13 @@
 server_cleanup (sig)
     int sig;
 {
     int status;
     int save_noexec;
+    static int already_in_cleanup = 0;
+
+    /* Make sure we don't get called recursively.  */
+    if (already_in_cleanup) return;
+    already_in_cleanup = 1;

     if (buf_to_net != NULL)
     {

-Larry Jones

It's hard to be religious when certain people are never
incinerated by bolts of lightning. -- Calvin


_______________________________________________
Info-cvs mailing list
address@hidden
http://mail.gnu.org/mailman/listinfo/info-cvs