Re: Building CVS on Windows is broken...again

[Derek Robert Price]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Larry Jones wrote:

>Derek Robert Price writes:
>
>>It allowed me to check for unsent data in the buffer where the getc()
>>used to block with the wrong combination of client and server.  Do you
>>not think this is worth it or do you have an alternative?
>
>
>Not only do I think it's not worth it, I think it's wrong.  A library
>function has no business second-guessing its caller.


The library is only second guessing its caller if it's not part of its
charter that its descriptors will not have data left at closing time.  I
would have to say that the duration of time the warning has been there
if there was data left at closing time makes this at least implicitly
part of the stdio_buffer_shutdown()'s charter.  Not that it necessarily
should be, but as things stand, every caller of that close routine would
then need to check for the extra data before closing the buffer.  I
guess a confirm_buffer_empty() function or the like could do the trick,
but until we have a reason to use buffer that wants to close a pipe with
data...

Derek

- --
                *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org

iD8DBQFAMZNMLD1OTBfyMaQRAqiHAJ9C77uBnQ2fsyh436BmjEcO90N2PACfYc4u
Q/6aF4YrIAdMJH+fsQKdyZc=
=sJmA
-----END PGP SIGNATURE-----