Re: add hook question (was Re: Problem with importing third-party sources and adding/committing changes)

[Paul Sander]

>--- Forwarded mail from address@hidden

>Derek Robert Price <address@hidden> writes:

>> Mark D. Baushke wrote:
>> 
>> > Hi Greg,
>> >
>> > Is it reasonable to suggest that a addinfo trigger could be run as a
>> > part of the 'cvs commit' command should the client not happen to connect
>> > to the server for a 'cvs add' operation?
>> 
>> 
>> It should probably run regardless since it would be much simpler than
>> securely tracking whether the add on the client side had contacted the
>> server.

>Good point.

Yes!

>> > The idea would be that having simpler triggers for various kinds of
>> > policy makes the administration of a repository easier.
>> >
>> > In a similar manner a trigger for 'cvs rm' could be implemented to
>> > impose policy.
>> 
>> 
>> Sure, but again, not by default.

>Sure.

I think that it should be enabled by default, and the user can put the
-n option in his .cvsrc file for the affected commands, both for add
and remove.

The reasons for this:
- It maintains compatibility with existing commands.
- The user is caught just once when the trigger fires.  Recovery is to
  interrupt the client, edit .cvsrc, and re-run.  In the converse, the
  user must ask for policy enforcement, and may never get around to it
  in violation of the project's policy.

Unfortunately, there appears to be no way to countermand a -n option,
so the only way to turn it off is to edit the .cvsrc file.

>--- End of forwarded message from address@hidden