[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: mechanisms for reviews needed

From: Dave Korn
Subject: RE: mechanisms for reviews needed
Date: Tue, 2 Aug 2005 20:49:45 +0100

----Original Message----
>From: Todd Denniston
>Sent: 02 August 2005 19:34

> But as someone else mentioned this is a management problem, and you need a
> management solution, however by using rcsinfo/verifymsg/commitinfo you can
> design and implement a technological helper for management's solution that
> actually matches YOUR management's desire. 

  Yep, that's exactly the sort of thing I envisage: a two-part solution

Part 1 - Technical - A commitinfo script that disallows any commit unless
the log message includes the string "Reviewed:" and a username.

Part 2 - Managerial - Explain that this system requires all checkins to be
reviewed, that the checker-in is responsible for getting their code
reviewed, and that bypassing the system by falsely adding a 'Reviewed' tag
for code that hasn't been reviewed will be regarded as an offence every bit
as serious as forging a manager's signature on an expense claim.

Can't think of a witty .sigline today....

reply via email to

[Prev in Thread] Current Thread [Next in Thread]