info-cvs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mechanisms for reviews needed


From: Todd Denniston
Subject: Re: mechanisms for reviews needed
Date: Tue, 02 Aug 2005 17:11:27 -0500

Jacob wrote:
> 
> Dave Korn wrote:
> 
> > Why not just _tell_ your engineers that they mustn't check-in unreviewed
> > code?
> 
> Sure.
> 
> And how will the reviewer(s) get to know about the changes
> and where will the changes be found? Inside the VCS would
> be quite natural, to me at least.

This is where another chunk of the management solution has to kick in,
because you have stated you don't want un-reviewed code in the repo (it's
either in the repo, or it is not[1]). 
In my situations the chunk of the management solution needed here was 'email
those people on the review team letting them know a) what bug number the
changes are for, b) where the sandbox is that needs reviewed, c) where your
engineering notebook (extra design decisions you made) is at, And Oh by the
way !DO NOT MAKE CHANGES TO THE SAND BOX AND NOTEBOOK YOU ARE HAVING
REVIEWED AFTER YOU SEND THE EMAIL!'. It could have just as easily been
`change a field in the bug tracking system and the control board
(management) will assign someone to review the code`.

[1] however you could state, but have not yet, that for you a special branch
could be considered 'not in the repo', i.e. , developer1 could say my
un-reviewed changes for bug 123 are on the tip of branch developer1_bug_123,
and when the review approves the changes they are merged from
developer1_bug_123 onto the production "branch" for everyone to use.
-- 
Todd Denniston
Crane Division, Naval Surface Warfare Center (NSWC Crane) 
Harnessing the Power of Technology for the Warfighter




reply via email to

[Prev in Thread] Current Thread [Next in Thread]