Re: [PATCH] IDL4 with GNU libl4

[Marcus Brinkmann]

On Tue, Nov 18, 2003 at 04:19:46PM +0100, Ludovic Court?s wrote:
> Hi,
> 
> Below is a small patch against IDL4 1.0.2-beta that modifies headers so
> that IDL4-generated code (which includes these headers) can compile with
> GNU libl4, the libl4 replacement written by Marcus Brinkmann.

You should have contacted me about this.  I don't support any efforts to use
my libl4 ouside of its current scope, which is the Hurd.  I also don't think
that any code in the world except for such code should even know that my
libl4 exists, nor use its interfaces.  This means that your patch is
completely wrong and unacceptable.

My libl4 should eventually be ABI and API compatible to the official ABI/API.
However, it would help to make IDL4 use official APIs instead accessing the
structs directly:

> +#ifndef L4_LABEL
> +# ifndef __GNU_LIBL4__
> +#  define L4_LABEL(_msgtag)  ((_msgtag).X.label)
> +# else
> +#  define L4_LABEL(_msgtag)  (l4_label ((_msgtag)))
> +# endif /* __GNU_LIBL4__ */
> +#endif

Just using L4_Label should be fine.

> +#ifndef L4_ERROR
> +# ifndef __GNU_LIBL4__
> +#  define L4_ERROR(_msgtag)  ((_msgtag).X.flags & 8)
> +# else
> +#  define L4_ERROR(_msgtag)  (l4_ipc_failed ((_msgtag)))
> +# endif
> +#endif

Just using L4_IpcFailed or however it's called should be fine.

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' GNU      http://www.gnu.org    address@hidden
Marcus Brinkmann              The Hurd http://www.gnu.org/software/hurd/
address@hidden
http://www.marcus-brinkmann.de/