[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Libcdio-devel] Re: [PATCH] OS/2 support
From: |
KO Myung-Hun |
Subject: |
[Libcdio-devel] Re: [PATCH] OS/2 support |
Date: |
Sat, 14 Feb 2009 20:37:02 +0900 |
User-agent: |
Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8.1.19) Gecko/20081217 SeaMonkey/1.1.14 Mnenhy/0.7.6.0 |
Hi/2.
Rocky Bernstein wrote:
Sorry for the delay. The OS2 patches should now be in the libcdio git
repository.
I had some problems applying the patch. (Patch wants the original listed
first, not second and it would have been helpful to attach this as a
separate file).
I have no way to check whether these changes work. So please double check my
work. (I often make mistakes ;-)
I've checked and it works fine. Thanks. ^^
But I think m4/iconv.m4 should be modified.
returning 1 means error, so it should be checked with '(size_t)(-1)' not
'0'.
--
KO Myung-Hun
Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM
Korean OS/2 User Community : http://www.ecomstation.co.kr
diff -buNr m4/iconv.m4.org m4/iconv.m4
--- m4/iconv.m4.org 2009-02-14 15:29:42.000000000 +0900
+++ m4/iconv.m4 2009-02-14 20:21:50.000000000 +0900
@@ -83,7 +83,7 @@
size_t res = iconv (cd_utf8_to_88591,
(char **) &inptr, &inbytesleft,
&outptr, &outbytesleft);
- if (res == 0)
+ if (res == (size_t)(-1))
return 1;
}
}