Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

[Thomas Schmitt]

Hi,

i pushed branch "joliet_multi_extent" with a new commit
  cb03533aaba6113465b19157577e631e26406c7e
  "Add test for proper handling of multi-extent files in the Joliet tree"

Please review and/or test.
Especially
  (cd test && ./check_multiextent.sh )
should report:
  -- ./check_multiextent.sh: ISO 9660 + Rock Ridge multiextent listing test ok.
  -- ./check_multiextent.sh: ISO 9660 + Rock Ridge multiextent read test ok.
  -- ./check_multiextent.sh: Joliet multiextent listing test ok.
  -- ./check_multiextent.sh: Joliet multiextent read test ok.

I tested that this branch can be merged into a branch made from "master"
(15801fb), compiles, and yields above test result.


Rocky Bernstein wrote:
> BTW, when creating ISO
> images please try to use the smallest amount of data that will do the job.

That's why i hack xorriso before making the test ISOs.
Normally a multi-extent ISO would be at least 4 GiB large.

The overhead of the old multi_extent_8k.iso consists entirely of zeros.
So within git and tar.gz there should be nearly no cost. Nevertheless
it is worthwhile to avoid those zeros.
So i made a new one by:

  xorriso -compliance no_emul_toc -padding 0 -joliet off -rockridge on \
          -outdev test/data/multi_extent_8k.iso \
          -map test/data/multi_extent_file /multi_extent_file


Have a nice day :)

Thomas