libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Wrt to Tru64


From: Gary V . Vaughan
Subject: Re: Wrt to Tru64
Date: Mon, 23 Apr 2001 10:06:23 +0100

On Monday 23 April 2001  7:47 am, you wrote:
> Hi ,
>
> > > ./ltconfig[633]: syntax error at line 1 : `COPYING' unexpected
> >
> > Wierd.  We will be interested to hear what you discover.
>
> I  found that the error message is because of a script error in
> ltcf-cxx.sh. I have  a fix for that.  But not sure whether it is correct or
> not .   But  then once I explain what is happening  some one else should be
>  able to check whether the patch I am sending is correct or not .  The '*
> 'in the
> 'output_verbose_link_cmds' is getting expand as the file list in the
> current directory . I have right now put a backslash "\" to indicase escape
> . But not sure it is the right way of fixing .

Thanks.  Good catch!

I think there is an underlying problem with the way output_verbose_link_cmds 
is not quoted prior to being `eval'ed.  By my reckoning, it should be passed 
through $sed_quote_subst before being fed to eval, otherwise technically 
variables will also be substituted at the wrong time.

Additionally, it breaks our naming convention: *_cmds variables should allow 
multiple lines of shell code to be used if separated by `~'s;  if a variable 
can hold only a single line of shell code, it should be name *_cmd.

Comments?

Cheers,
        Gary.
-- 
  ___              _   ___   __              _         mailto: address@hidden
 / __|__ _ _ ___ _| | / / | / /_ _ _  _ __ _| |_  __ _ ___       address@hidden
| (_ / _` | '_|// / |/ /| |/ / _` | || / _` | ' \/ _` | _ \
 \___\__,_|_|\_, /|___(_)___/\__,_|\_,_\__, |_||_\__,_|//_/
home page:  /___/                      /___/                  gpg public key:
http://www.oranda.demon.co.uk           http://www.oranda.demon.co.uk/key.asc



reply via email to

[Prev in Thread] Current Thread [Next in Thread]