[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: ltdl.c patch
From: |
Gary V . Vaughan |
Subject: |
Re: ltdl.c patch |
Date: |
Wed, 25 Jul 2001 03:53:24 +0100 |
On Tuesday 24 July 2001 8:18 pm, Steve Ellcey wrote:
> I noticed that it is possible to try and free "canonical" in
> foreach_dirinpath even if it is never initialized, for instance if we go
> into one of the initial ifs at the start of foreach_dirinpath that has a
> "goto cleanup" in it. This simple patch just initializes canonical to 0
> so we don't try to free an undefined pointer. It will result in us
> trying to free a NULL pointer but LT_DLFREE seems to deal with that.
Good catch. Thanks!
I am applying this now, but I have a revamped version in development which
takes advantage of glibc's argz API if it is available that I'll probably
submit for approval tomorrow.
Don't forget to send a ChangeLog next time...
> I have a copyright assignment on file but no write permssion to the
> CVS tree.
No worries... our rule of thumb is that you must add (or substantially
change) 10 or more lines of code to require an assignment.
Cheers,
Gary.
--
())_. Gary V. Vaughan gary@(oranda.demon.co.uk|gnu.org)
( '/ Research Scientist http://www.oranda.demon.co.uk ,_())____
/ )= GNU Hacker http://www.gnu.org/software/libtool \' `&
`(_~)_ Tech' Author http://sources.redhat.com/autobook =`---d__/
- ltdl.c patch, Steve Ellcey, 2001/07/24
- Re: ltdl.c patch,
Gary V . Vaughan <=