libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

libltdl/ltdl.c call to access() failure


From: Robert Boehne
Subject: libltdl/ltdl.c call to access() failure
Date: Tue, 17 Sep 2002 11:59:39 -0500

Hello,

Per the discussion on the libtool mailing list:
http://mail.gnu.org/pipermail/libtool/2002-September/006692.html
Here is a patch to temporarily work around the problem.
This change causes three test failures to pass on
several UNIX platforms.
I'd like to remove this call for the time being, and we'll put it back
when the problem is resolved.

Ok to commit?

2002-09-17  Robert Boehne  <address@hidden>

        * libltdl/ltdl.c: Commented out access() call that checks for a
        library file's existence and permissions, as it appears to fail
        in every case.

-- 
Robert Boehne             Software Engineer
Ricardo Software   Chicago Technical Center
TEL: (630)789-0003 x. 238
FAX: (630)789-0127
email:  rboehne AT ricardo-us DOT com

Index: libltdl/ltdl.c
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/ltdl.c,v
retrieving revision 1.169
diff -u -r1.169 ltdl.c
--- libltdl/ltdl.c      28 Aug 2002 20:40:28 -0000      1.169
+++ libltdl/ltdl.c      17 Sep 2002 16:58:31 -0000
@@ -2033,14 +2033,17 @@
   cur = *handle;
   if (filename)
     {
+      /* Comment out the check of file permissions using access.
+        This call seems to always return -1 with error EACCES.
+      */
       /* We need to catch missing file errors early so that
-        file_not_found() can detect what happened. */
+        file_not_found() can detect what happened.
       if (access (filename, R_OK) != 0)
        {
          LT_DLMUTEX_SETERROR (LT_DLSTRERROR (FILE_NOT_FOUND));
          ++errors;
          goto done;
-       }
+       } */
 
       cur->info.filename = lt_estrdup (filename);
       if (!cur->info.filename)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]