Re: FYI: 100-gary-libtool-documentation-audit.patch

[Alexandre Duret-Lutz]

>>> "Gary" == Gary V Vaughan <address@hidden> writes:


 Gary> Index: ChangeLog
 Gary> from  Gary V. Vaughan  <address@hidden>
 Gary> 
 Gary>  * doc/libtool.texi: This manual has not been maintained properly
 Gary>  for a number of years.  Much of what it said was outdated, or
 Gary>  plain wrong with reference to modern autotools.  This change
 Gary>  represents a first pass edit to clean up the obviously wrong.

Congrats!

Here are a couple of nits I noticed (I haven't read the full
patch in detail -- it's way too long).

[...]

 Gary> +With recent @sc{gnu} Automake (1.8 or newer), the flags @samp{-dlopen}
 Gary> +or @samp{-dlpreopen} (@pxref{Link mode}) can be employed with the
 Gary> address@hidden variable.  

It's "1.5 or newer"

[...]

 Gary> +People used to add code like the following to their
 Gary> address@hidden:
 
 Gary> address@hidden LTLIBOBJS
 Gary> @example
 Gary> LTLIBOBJS=`echo "$LIBOBJS" | sed 's/\.[^.]* /.lo /g;s/\.[^.]*$/.lo/'`
 Gary> AC_SUBST(LTLIBOBJS)
 Gary> -LTALLOCA=`echo "$ALLOCA" | sed 's/\.[^.]* /.lo /g;s/\.[^.]*$/.lo/'`
 Gary> -AC_SUBST(LTALLOCA)
 Gary> -AC_OUTPUT(@dots{})
 Gary> @end example
 
 Gary> address@hidden
 Gary> +This is not only no longer required (since Autoconf 2.50), but will
 Gary> +in fact trigger error messages from Autoconf 2.53 and newer.  Further,
 Gary> +this code doesn't take Automake's deansification support into account,
 Gary> +so wouldn't work correctly in that case even with ancient Autoconfs!
 Gary> +
 Gary> +Provided you are using a recent (2.50 or better) incarnation of
 Gary> +Autoconf, the call to @code{AC_OUTPUT} takes care of setting
 Gary> address@hidden up correctly, so you can simply delete such snippets
 Gary> +from your @file{configure.ac} if you had them.

AC_OUTPUT defines LTLIBOBJS only since Autoconf 2.54.

The error message added in 2.53 is against direct assignments to LIBOBJS
(i.e. LIBOBJS="$LIBOBJS foo.o" should be replaced by AC_LIBOBJ([foo]))

[...]

 Gary> @@ -3670,67 +3811,12 @@ SUBDIRS = libltdl
 Gary> INCLUDES = $(LTDLINCL)

AM_CPPFLAGS = $(LTDLINCL)

[...]

-- 
Alexandre Duret-Lutz