Re: config/ltmain.sh in srcdir contains hard-coded path!

[Albert Chin]

On Wed, Sep 08, 2004 at 10:05:39PM -0500, Albert Chin wrote:
> On Wed, Sep 08, 2004 at 09:21:05PM -0500, Bob Friesenhahn wrote:
> > It seems that everything is working against me this evening. :-(
> > 
> > I have learned that when CVS libtool is bootstrapped, it hard-codes a 
> > path into $(srcdir)/config/ltmain.sh.  In fact, for a VPATH build, 
> > config/ltmain.sh should always be created in the build directory and 
> > should *never* appear in the "read-only" source tree.
> > 
> > The path which caught my attention was
> > 
> > : ${MKDIR_P="/home/bfriesen/src/gnu/libtool/config/install-sh -d"}
> > 
> > My build machine (a Windows box accessing the sources via SMB) already 
> > uses the path "/home/bfriesen" for its own purposes so the libtool 
> > sources are accessed via a somewhat different path.
> 
> As far as I'm concerned, the addition of @mkdir_p@ is broken:
>   http://lists.gnu.org/archive/html/libtool-patches/2004-09/msg00064.html
> 
> @mkdir_p@ can be one of three values:
>   1. mkdir -p --
>   2. $(mkinstalldirs)
>   3. $(install_sh) -d
> 
> #2 and #3 require programs to be installed when 'make install' is run
> and be accessible to the generated libtool. From your snippet above,
> looks like install-sh is accessible. However, for #2, I get:
>   : ${MKDIR_P="/bin/bash ./config/mkinstalldirs"}
> 
> Clearly this won't work as we don't have an absolute path.

I just thought about something else. Does config/ltmain.sh get copied
to $(prefix) as the ltmain.sh that should go in distribution tarballs?
If so, @mkdir_p@ is even more broken. Say someone copies in a
config/ltmain.sh from a RH box with MKDIR_P='mkdir -p --'. This means
the distribution ltmain.sh will use 'mkdir -p --' even if run on a
Solaris box, which found 'mkdir -p --' unacceptable above. Unless
@mkdir_p@ can be detected from m4/libtool.m4, I say we jettison it.
And, even then, it will force the distribution to have a copy of
mkinstalldirs or install-sh.

-- 
albert chin (address@hidden)