Re: FYI: libtool--devo--1.0--patch-180

[Gary V . Vaughan]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Albert,

On 14 Sep 2004, at 23:59, Albert Chin wrote:

> On Tue, Sep 14, 2004 at 11:47:42PM +0100, Gary V. Vaughan wrote:
> > Index: Changelog
> > from  Gary V. Vaughan  <address@hidden>
> >
> >         * config/ltmain.in (func_quote_for_eval): Factor out the ugly
> >         shell meta-character quoting.  Changed all callers.
>
> Is this an improvement?

Sure (except that it introduced a regression).  Almost always, I'll 
trade speed for maintainability (and by implication, long term 
correctness).

> It slows down libtool because you're forking every time you call 
> func_quote_for_eval().

Yeah.  I'll buy that, especially for hosts where fork is expensive, and
there is a precedent for this in libtool funcs already... see 
- --patch-181.

Cheers,
        Gary.
- --
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (Darwin)

iD8DBQFBR5cSFRMICSmD1gYRAiJBAJkBFzJZFn7YqsSSU2W7DYJ0g1luCgCgrqND
v6F3Wbr+Te43/CxqdPQORsU=
=KxEM
-----END PGP SIGNATURE-----