libtool-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

show function pointer evaluations


From: Ralf Wildenhues
Subject: show function pointer evaluations
Date: Mon, 27 Sep 2004 19:55:07 +0200
User-agent: Mutt/1.4.1i

I know this is not required by ANSI C (and thus not a bug per se), but
it's IMVHO clearer to see where function pointers are evaluated.
(and, what's more, it helps me finding these other nasty bugs :)

Regards,
Ralf

2004-09-27  Ralf Wildenhues <address@hidden>

        * libltdl/lt_dlloader.c (lt_dlloader_remove), libltdl/ltdl.c
        (tryall_dlopen, lt_dlhandle_next): Show usage of function pointers.


Index: libltdl/lt_dlloader.c
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/lt_dlloader.c,v
retrieving revision 1.5
diff -u -r1.5 lt_dlloader.c
--- libltdl/lt_dlloader.c       2 Sep 2004 12:55:31 -0000       1.5
+++ libltdl/lt_dlloader.c       27 Sep 2004 19:01:09 -0000
@@ -145,7 +145,7 @@
   /* Call the loader finalisation function.  */
   if (vtable && vtable->dlloader_exit)
     {
-      if (vtable->dlloader_exit (vtable->dlloader_data) != 0)
+      if ( (*vtable->dlloader_exit) (vtable->dlloader_data) != 0)
        {
          /* If there is an exit function, and it returns non-zero
             then it must set an error, and we will not remove it
Index: libltdl/ltdl.c
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/ltdl.c,v
retrieving revision 1.213
diff -u -r1.213 ltdl.c
--- libltdl/ltdl.c      2 Sep 2004 13:27:24 -0000       1.213
+++ libltdl/ltdl.c      27 Sep 2004 19:01:09 -0000
@@ -361,7 +361,7 @@
     while ((loader = lt_dlloader_next (loader)))
       {
        vtable = lt_dlloader_get (loader);
-       handle->module = vtable->module_open (vtable->dlloader_data, filename);
+       handle->module = (*vtable->module_open) (vtable->dlloader_data, 
filename);
 
        if (handle->module != 0)
          {
@@ -2110,7 +2121,7 @@
 
   /* advance until the interface check (if we have one) succeeds */
   while (handle && iterator && iterator->iface
-        && (iterator->iface (handle, iterator->id_string) != 0))
+        && ( (*iterator->iface) (handle, iterator->id_string) != 0))
     {
       handle = handle->next;
     }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]