[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
cygwin breakage
From: |
Charles Wilson |
Subject: |
cygwin breakage |
Date: |
Fri, 15 Oct 2004 12:58:39 -0400 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040616 MultiZilla/1.6.4.0b |
The combination of Peter's recent two patches:
45-peter-eval_show.patch
46-peter-revert_eval_show.patch
Which, in the end, results simply in
--- ltmain.m4sh.1 2004-10-15 10:25:26.140625000 -0400
+++ ltmain.m4sh 2004-10-15 10:25:59.390625000 -0400
@@ -5135,7 +5135,8 @@
for cmd in $cmds; do
IFS="$save_ifs"
eval cmd=\"$cmd\"
- $show "$cmd"
+ func_quote_for_eval "$cmd"
+ eval \$show \"$func_quote_for_eval_result\"
$run eval "$cmd" || {
lt_exit=$?
manages to break these regression test on cygwin
PASS: mdemo-conf.test
-PASS: mdemo-make.test
-PASS: mdemo-exec.test
-PASS: mdemo-inst.test
-PASS: mdemo-unst.test
-PASS: mdemo-dryrun.test
+FAIL: mdemo-make.test
+SKIP: mdemo-exec.test
+SKIP: mdemo-inst.test
+SKIP: mdemo-unst.test
+FAIL: mdemo-dryrun.test
PASS: mdemo2-conf.test
-PASS: mdemo2-make.test
-PASS: mdemo2-exec.test
+SKIP: mdemo2-make.test
+SKIP: mdemo2-exec.test
PASS: mdemo-shared.test
-PASS: mdemo-make.test
-PASS: mdemo-exec.test
-PASS: mdemo-inst.test
-PASS: mdemo-unst.test
+FAIL: mdemo-make.test
+SKIP: mdemo-exec.test
+SKIP: mdemo-inst.test
+SKIP: mdemo-unst.test
Peter, what EXACTLY were you trying to fix? Was something actually
broken, or did the previous WORKING code offend your sense of elegance?
(No, I'm not real happy).
I strongly request that unnecessary "cleanup" patches NOT be committed
to the 2.0 branch, unless they actually FIX real, existing problems --
or are tested on all major platforms and do no harm.
This patch DOES harm. Please revert or fix it.
--
Chuck