[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] ar xN fixes for HEAD
From: |
Peter O'Gorman |
Subject: |
Re: [patch] ar xN fixes for HEAD |
Date: |
Wed, 15 Dec 2004 12:05:54 +0900 |
User-agent: |
Mozilla Thunderbird 1.0 (Macintosh/20041206) |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Albert Chin wrote:
| On Tue, Dec 14, 2004 at 11:49:49PM +0900, Peter O'Gorman wrote:
|
|>+ $AR t "$f_ex_an_ar_oldlib" | sort | uniq -c \
|>+ | $EGREP -v '^[ ]*1[ ]' | while read -r count name
|
|
| Why the $EGREP? Mac OS X?
Nope, the 1.5 branch does not have GREP and I neglected to change it :)
| On Tru64 UNIX, count == 1 for non-unique objects. Don't you want to
| enter the while loop only when $count > 1? That's why I had the
| following in my patch:
| test "$count" -eq 1 && continue
Yes, I saw your patch, but thought "6 of one, a half dozen of the other" the
effect is the same. I'd be happy enough to change to your method if people
find it more readable.
|
| Why not "$AR d" instead of "$AR -d"? You already use "$AR x".
|
Just me being typically inconsistent (I'll change before applying).
Thank you,
Peter
- --
Peter O'Gorman - http://www.pogma.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iQCVAwUBQb+qEriDAg3OZTLPAQIfowQAqdsZPNKYWhmjQnQhC2ghvp1xg8osmYaP
d/HF+LVNhtmTBUZ+v1GkwjW0AlVw8rql81spp0wBHf9tKHwJBNADVeWjLUrWj/6r
69KjOfWZf8/2opfAdlJGTqS8prVj7FmfOi+Ayqol6iQioii3pQd3WkW6V+LkvRrq
IEzPcdC7ErI=
=UgD2
-----END PGP SIGNATURE-----